Skip to content

[Backport] Complete the fix for cache issue due to the currencies with no symbol #16132

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

[Backport] Complete the fix for cache issue due to the currencies with no symbol #16132

wants to merge 1 commit into from

Conversation

@hitesh-wagento
Copy link
Contributor

@hitesh-wagento hitesh-wagento commented Jun 14, 2018

Original Pull Request

#15902

Description

Using getCurrencySymbol() leads to a bug for currencies where there is no currency symbol - cache ends up being non-unique. Using currency code for caching is a more foolproof way.

The issue has been partially fixed in 2.2-develop branch in #13894 (Magento\ConfigurableProduct\Block\Product\View\Type\Configurable)
and #14559 (Magento\CatalogWidget\Block\Product\ProductsList).

Manual testing scenarios

  1. Test the Catalog Category View page (including configurable products)
  2. Test the Catalog Product List widget

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@magento-engcom-team magento-engcom-team added Partner: Wagento Pull Request is created by partner Wagento partners-contribution Pull Request is created by Magento Partner Component: Catalog labels Jun 14, 2018
@dmytro-ch
Copy link
Contributor

dmytro-ch commented Jun 14, 2018

This PR should be closed since it does not contain all the needed changes for Magento 2.1 version and actually does not fix the mentioned issue.
Here is the original backport to 2.1-develop branch: #15781

Thanks.

@lfluvisotto
Copy link
Contributor

lfluvisotto commented Jun 14, 2018

PR rejected, priority granted to the original PR author.

#15902 (2.2-develop) (original)

#15781 (2.1-develop) (backport)

@hitesh-wagento hitesh-wagento deleted the 2.1-develop-PR-port-15902 branch September 6, 2018 06:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

Component: Catalog Partner: Wagento Pull Request is created by partner Wagento partners-contribution Pull Request is created by Magento Partner

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@hitesh-wagento @dmytro-ch @lfluvisotto @magento-engcom-team